This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Finish __builtin_expect -> __glibc_{un}likely cleanup in elf/dl-load.c
- From: Andreas Schwab <schwab at suse dot de>
- To: OndÅej BÃlka <neleai at seznam dot cz>
- Cc: Paul Pluzhnikov <ppluzhnikov at google dot com>, libc-alpha at sourceware dot org
- Date: Thu, 27 Mar 2014 12:51:56 +0100
- Subject: Re: [patch] Finish __builtin_expect -> __glibc_{un}likely cleanup in elf/dl-load.c
- Authentication-results: sourceware.org; auth=none
- References: <ye6qeh1o7ab8 dot fsf at elbrus2 dot mtv dot corp dot google dot com> <20140327114201 dot GA32440 at domone dot podge>
OndÅej BÃlka <neleai@seznam.cz> writes:
> if (__glibc_unlikely (l->l_faked != 0)
> continue;
> if (__builtin_expect (l->l_removed, 0) != 0)
> continue;
__builtin_expect should really only be used in boolean context, ie. this
should be written as:
if (__builtin_expect (l->l_removed != 0, 0))
continue;
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."