This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/2] Separate ftell from fseek logic and avoid modifying FILE data (#16532)

From: Mike Frysinger <vapier at gentoo dot org>
To: libc-alpha at sourceware dot org
Cc: Siddhesh Poyarekar <siddhesh at redhat dot com>, Andreas Schwab <schwab at suse dot de>, Carlos O'Donell <carlos at redhat dot com>
Date: Thu, 27 Mar 2014 03:38:33 -0400
Subject: Re: [PATCH 1/2] Separate ftell from fseek logic and avoid modifying FILE data (#16532)
Authentication-results: sourceware.org; auth=none
References: <20140220172904 dot GC16378 at spoyarek dot pnq dot redhat dot com> <mvmeh1qmrje dot fsf at hawking dot suse dot de> <20140325115032 dot GE1850 at spoyarek dot pnq dot redhat dot com>

On Tue 25 Mar 2014 17:20:32 Siddhesh Poyarekar wrote:
> On Tue, Mar 25, 2014 at 12:44:21PM +0100, Andreas Schwab wrote:
> > > -	tst-fwrite-error tst-ftell-partial-wide
> > > +	tst-fwrite-error tst-ftell-partial-wide tst-ftell-active-handler
> > > 
> > >  ifeq (yes,$(build-shared))
> > >  # Add test-fopenloc only if shared library is enabled since it depends
> > >  on
> > >  # shared localedata objects.
> > 
> > You need to set up LOCPATH so that the tests can find their locales.
> > Installed as obvious.
> 
> I wonder if it would be useful to set LOCPATH all the time so that we
> don't have to bother with doing it for individual tests.

seems reasonable to move into the main testrunner logic
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

References:
- Re: [PATCH 1/2] Separate ftell from fseek logic and avoid modifying FILE data (#16532)
  - From: Andreas Schwab
- Re: [PATCH 1/2] Separate ftell from fseek logic and avoid modifying FILE data (#16532)
  - From: Siddhesh Poyarekar

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]