This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Make x86_64 fegetenv preserve exception mask (bug 16198)


On Wed, Mar 26, 2014 at 10:37 AM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
> Bug 16198 is x86_64 fegetenv wrongly masking exceptions for which
> traps are enabled, because that's a side-effect of the fnstenv
> instruction.  This patch fixes it to use fldenv immediately after
> fnstenv, like the i386 version.  Tested x86_64 and x86.
>
> 2014-03-26  Joseph Myers  <joseph@codesourcery.com>
>
>         [BZ #16198]
>         * sysdeps/x86_64/fpu/fegetenv.c (fegetenv): Use fldenv after
>         fnstenv.
>         * math/test-fenv-preserve.c: New file.
>         * math/Makefile (tests): Add test-fenv-preserve.
>

Looks good to me.  Thanks.

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]