This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Fix -Wundef warning for ONE_DIRECTION in iconv/skeleton.c


All places that define ONE_DIRECTION define it to 1, so I think this is
the right way to fix the warning.

Andreas.

	* iconv/skeleton.c (ONE_DIRECTION): Check for definedness, not
	value.
---
 iconv/skeleton.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/iconv/skeleton.c b/iconv/skeleton.c
index 14318a6..d1b89b0 100644
--- a/iconv/skeleton.c
+++ b/iconv/skeleton.c
@@ -564,7 +564,7 @@ FUNCTION_NAME (struct __gconv_step *step, struct __gconv_step_data *data,
 					outend, lirreversiblep
 					EXTRA_LOOP_ARGS);
 # endif
-# if !ONE_DIRECTION
+# ifndef ONE_DIRECTION
 #  if FROM_LOOP_MAX_NEEDED_FROM > 1 && TO_LOOP_MAX_NEEDED_FROM > 1
 	  else
 #  endif
-- 
1.9.1

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]