This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove PRI_MACROS_BROKEN define usage
- From: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 20 Mar 2014 21:35:07 -0300
- Subject: Re: [PATCH] Remove PRI_MACROS_BROKEN define usage
- Authentication-results: sourceware.org; auth=none
- References: <532B3168 dot 2030108 at linux dot vnet dot ibm dot com> <Pine dot LNX dot 4 dot 64 dot 1403201832040 dot 29670 at digraph dot polyomino dot org dot uk> <532B3750 dot 2030102 at linux dot vnet dot ibm dot com> <Pine dot LNX dot 4 dot 64 dot 1403201848000 dot 29670 at digraph dot polyomino dot org dot uk> <532B3F64 dot 6030005 at linux dot vnet dot ibm dot com> <Pine dot LNX dot 4 dot 64 dot 1403210000380 dot 23226 at digraph dot polyomino dot org dot uk>
On 20-03-2014 21:01, Joseph S. Myers wrote:
> On Thu, 20 Mar 2014, Adhemerval Zanella wrote:
>
>> Ok, I check with gettext implementation
>> 'gettext-runtime/intl/loadmsgcat.c' and changed the initial patch based
>> on your suggestion (I also added some changes to make glibc one similar
>> to gettext one).
> Any change brought from gettext would best be committed on its own
> (ideally with the original author of that change in gettext being
> credited).
>
The changes I have incorporated on the patch is just change the old K&R
function prototype to ISO C, remove and superfluous ';' and change a
free call to remove an unnecessary cast. For these straightforward patches
do we really need to track the ones how made then and commit a set of
patches?