This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix -Wundef warnins for __FP_FAST_FMA*
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>, Roland McGrath <roland at hack dot frob dot com>
- Cc: libc-alpha at sourceware dot org, "Joseph S. Myers" <joseph at codesourcery dot com>
- Date: Wed, 19 Mar 2014 00:16:26 -0400
- Subject: Re: [PATCH] Fix -Wundef warnins for __FP_FAST_FMA*
- Authentication-results: sourceware.org; auth=none
- References: <20140318020544 dot GO1850 at spoyarek dot pnq dot redhat dot com> <5327CDCD dot 6030006 at redhat dot com> <20140318050711 dot GP1850 at spoyarek dot pnq dot redhat dot com> <5328510F dot 3050003 at redhat dot com> <20140318223618 dot A6F397447D at topped-with-meat dot com> <20140319020509 dot GA1850 at spoyarek dot pnq dot redhat dot com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 03/18/2014 10:05 PM, Siddhesh Poyarekar wrote:
> On Tue, Mar 18, 2014 at 03:36:18PM -0700, Roland McGrath wrote:
>> In short, these are the difficult cases. I'd kind of figured we'd knock
>> out all the cases in private code before tackling the nontrivial installed
>> header cases.
>
> This case fixes about 2100 warnings, which is why it came up first on
> my list.
Let's check this in then. As Roland suggests the only thing to avoid
is the use of this constant *again* in an #ifdef.
Cheers,
Carlos.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJTKRoaAAoJECXvCkNsKkr/aysIAInhEW/QSfWSZTGziltQJrlM
E6MnF2BIzWFINsuyUt1D2lV39r3okroNm6D1vpXqqPalc8wGd+kDOWIr7Axv7Pdx
vLM1WdNoo/SA6BaJiyzETn3ubucJWmXLvQ/AG8Zh9j0qwZH7sz6T5FsMUaLtaU6R
nUUw5uDvIQwKHdnMQKlmrLjtLWgYu3KLWSLCvJCQ9ZdselrWf2B7MB3PK5zUBjrb
pg4MQ8y4UxEUEmXt2gnWf7px4nA7JdYihxg2PGkptikfXCiJvP57TlL4MbkgIldn
iUEZ43jAY/GzNoJhKTdKfCnhfH3PfTp5b5ObN9Z41h54kkcYCCDqoqMcDbthiew=
=hUhP
-----END PGP SIGNATURE-----