This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/7] Fix __PTHREAD_MUTEX_HAVE_ELISION -Wundef warning
- From: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- To: libc-alpha at sourceware dot org
- Date: Tue, 18 Mar 2014 09:28:01 -0300
- Subject: Re: [PATCH 1/7] Fix __PTHREAD_MUTEX_HAVE_ELISION -Wundef warning
- Authentication-results: sourceware.org; auth=none
- References: <1395059004-20960-1-git-send-email-will dot newton at linaro dot org> <20140317182818 dot 5EAD474457 at topped-with-meat dot com> <20140317183732 dot C5A2374458 at topped-with-meat dot com> <532749D3 dot 3080008 at linux dot vnet dot ibm dot com> <20140317195304 dot 3AA2174461 at topped-with-meat dot com>
On 17-03-2014 16:53, Roland McGrath wrote:
>> For 788bba368c2eaf8aa3fd2ca18d269395d6bc8afb I still think the ifdef for
>> __PTHREAD_MUTEX_HAVE_ELISION is the way to go, since it fallows the
>> __PTHREAD_MUTEX_HAVE_PREV logic already in place and avoid adds another
>> default header or add more arch specific logic for arch that do not
>> support it.
> Someone should audit all the related #if logic and describe what it's
> doing. Then we can consider how best to rework it to be typo-proof.
>
So your idea is also to refactor __PTHREAD_MUTEX_HAVE_PREV to use as #if ... along with
__PTHREAD_MUTEX_HAVE_ELISION then? Both defines are set by arch specific headers,
so would be the idea to just a generic pthread header (or use an existing one) to
define them to default values?