This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/7] Fix __PTHREAD_MUTEX_HAVE_ELISION -Wundef warning
- From: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- To: libc-alpha at sourceware dot org
- Date: Mon, 17 Mar 2014 16:15:31 -0300
- Subject: Re: [PATCH 1/7] Fix __PTHREAD_MUTEX_HAVE_ELISION -Wundef warning
- Authentication-results: sourceware.org; auth=none
- References: <1395059004-20960-1-git-send-email-will dot newton at linaro dot org> <20140317182818 dot 5EAD474457 at topped-with-meat dot com> <20140317183732 dot C5A2374458 at topped-with-meat dot com>
On 17-03-2014 15:37, Roland McGrath wrote:
> To clarify, I object to
> commit 9290130a8de3f30970f741c79dfe8459f798e05f
> commit f7efd7c3dfffa3c417e9d3c4cb19d9954a3b1421
> commit 53f1bed39263541ef7f3d86f9701005524938016
> commit 788bba368c2eaf8aa3fd2ca18d269395d6bc8afb
>
> They should be reverted and proper fixes discussed here and reviewed with
> more care than these got.
>
For 788bba368c2eaf8aa3fd2ca18d269395d6bc8afb I still think the ifdef for
__PTHREAD_MUTEX_HAVE_ELISION is the way to go, since it fallows the
__PTHREAD_MUTEX_HAVE_PREV logic already in place and avoid adds another
default header or add more arch specific logic for arch that do not
support it.