This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] sotruss: convert from ksh to bash
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 13 Mar 2014 15:30:05 -0700 (PDT)
- Subject: Re: [PATCH v2] sotruss: convert from ksh to bash
- Authentication-results: sourceware.org; auth=none
- References: <1390644580-25234-1-git-send-email-vapier at gentoo dot org> <2683351 dot sTNi7IfGEu at vapier> <11174511 dot vyN9KHlfPq at vapier> <1513046 dot Pq6yaohzbx at vapier>
> This script works fine under bash (which we already require), so tweak
> the code to be pure bash.
I don't think we've documented anywhere that our installed scripts require
bash. Some of them already do, so this is not something you're changing
here. But before "we already require foo" should generally be considered
an adequate rationale for a change by itself, it should be a requirement
that we have made explicit and documented, rather than just a de facto
requirement that might have snuck in without clear intent.
I think removing the ksh check is fine.
I also think the changes to the script are fine, but they are purely
cosmetic and wholly unnecessary. Your "pure bash" and "to match bash"
comments seem to imply that "function foo {" style is somehow less
supported by bash than "foo() {", which AFAIK has never been the case.