This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Inline useless nested function mi_arena.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: OndÅej BÃlka <neleai at seznam dot cz>, libc-alpha at sourceware dot org
- Date: Thu, 27 Feb 2014 01:27:51 -0500
- Subject: Re: [PATCH] Inline useless nested function mi_arena.
- Authentication-results: sourceware.org; auth=none
- References: <20140226214924 dot GA10204 at domone dot podge>
On 02/26/2014 04:49 PM, OndÅej BÃlka wrote:
> Hi,
>
> I noticed a minor simplification in malloc_info, that nested function
> mi_arena looks useless as it gets called at only one site and I do not
> have to rename its argument. The resulting patch is big due of
> reindenting but is simple in principle.
>
> Is there any deep reason to keep it?
Having the per-arena malloc_info actions broken out into a
logical block makes the malloc_info code easier to read
and understand.
> * malloc/malloc.c (malloc_info): Inline mi_arena.
Make it a real function please? That way the generated debug
information is better.
Cheers,
Carlos.