This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Allow inclusion of sysdep.h and sys/auxv.h at build time
- From: Alan Modra <amodra at gmail dot com>
- To: Adam Conrad <adconrad at 0c3 dot net>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 20 Feb 2014 17:54:12 +1030
- Subject: Re: [PATCH] Allow inclusion of sysdep.h and sys/auxv.h at build time
- Authentication-results: sourceware.org; auth=none
- References: <20140220063943 dot GV22181 at 0c3 dot net>
On Wed, Feb 19, 2014 at 11:39:43PM -0700, Adam Conrad wrote:
> On powerpc and sparc, one can't include sys/auxv.h at build time, due
> to a header guard clash with sysdep.h. This is a non-issue at runtime,
> as sysdep.h is an internal header not exposed to userspace, but it does
> mean that either the testsuite can't include sys/auxv.h (as tst-auxv.c
> does), or the includes need to be mangled to make it work. This simple
> patch gets around that. Okay to commit?
>
> * sysdeps/powerpc/bits/hwcap.h: Allow _SYSDEPS_SYSDEP_H guard as a
> synonym for _SYS_AUXV_H to allow direct inclusion.
> * sysdeps/sparc/bits/hwcap.h: Likewise.
> * sysdeps/powerpc/sysdep.h: Define _SYSDEPS_SYSDEP_H instead of
> _SYS_AUXV_H so we can include sysdep.h and sys/auxv.h together.
> * sysdeps/sparc/sysdep.h: Likewise.
Looks reasonable.
--
Alan Modra
Australia Development Lab, IBM