This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH roland/comma-warnings] Avoid comma operator warnings.
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: "GNU C. Library" <libc-alpha at sourceware dot org>
- Date: Sat, 8 Feb 2014 00:22:31 +0100
- Subject: Re: [PATCH roland/comma-warnings] Avoid comma operator warnings.
- Authentication-results: sourceware.org; auth=none
- References: <20140131191419 dot AF0A574430 at topped-with-meat dot com>
On Fri, Jan 31, 2014 at 11:14:19AM -0800, Roland McGrath wrote:
> I'd just put this in if we weren't in release freeze. I think it's
> harmless enough to go in immediately, but it's certainly not urgent.
>
> include/signal.h and malloc-machine.h are for internal use only, so GCC
> extensions are fine unconditionally. The generic bits/sigset.h is only
> used by non-Linux configurations where there is no history of supporting
> compilers older than GCC 2.x, so __extension__ ({...}) is always fine.
>
> The build I'm doing now so as to notice these warnings is with a compiler
> based on today's GCC trunk, so this warning behavior might not manifest in
> any released compiler version.
>
>
Could these be pushed?