This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [MTASCsft PATCH 36/??] MT-, AS- and AC-Safety docs: manual/time.texi
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: <codonell at redhat dot com>, <libc-alpha at sourceware dot org>
- Date: Sun, 02 Feb 2014 21:49:53 -0200
- Subject: Re: [MTASCsft PATCH 36/??] MT-, AS- and AC-Safety docs: manual/time.texi
- Authentication-results: sourceware.org; auth=none
- References: <ortxelb5zd dot fsf at livre dot home> <or4n4uoncj dot fsf at livre dot home> <ormwigenp8 dot fsf_-_ at livre dot home> <Pine dot LNX dot 4 dot 64 dot 1402022255080 dot 7179 at digraph dot polyomino dot org dot uk>
On Feb 2, 2014, "Joseph S. Myers" <joseph@codesourcery.com> wrote:
> On Tue, 28 Jan 2014, Alexandre Oliva wrote:
>> @@ -778,6 +931,19 @@ available. @code{timelocal} is rather rare.
>> @comment time.h
>> @comment ???
>> @deftypefun time_t timegm (struct tm *@var{brokentime})
>> +@safety{@prelim{}@mtsafe{@mtsenv{} @mtslocale{}}@asunsafe{@ascuheap{} @asulock{}}@acunsafe{@aculock{} @acsmem{} @acsfd{}}}
>> +@c timegm @mtsenv @mtslocale @ascuheap @asulock @aculock @acsmem @acsfd
>> +@c gmtime_offset triggers the same caveats as localtime_offset in mktime.
>> +@c although gmtime_r, as called by mktime, might save some issues,
>> +@c tzset calls tzset_internal with always, which forces
>> +@c reinitialization, so all issues may arise.
>> +@c tzset dup @mtsenv @mtslocale @ascuheap @asulock @aculock @acsmem @acsfd
>> +@c mktime_internal(gmtime_r) @asulock @aculock
>> +@c...gmtime_r @asulock @aculock
> I see a build (well, "make install") failure (makeinfo 4.13):
> time.texi:942: Unknown command `c...gmtime'.
> Have all these late changes been tested with both Texinfo 4.x and Texinfo
> 5.x, for building info/html/pdf output?
I tested them all with make info, make pdf, and make html. I see I'm
using Texinfo 5.1.
I grepped all *.texi files, including the pending patches, for ^@c[^ \t]
| -v ^@\(cindex\ \|code{\)', and caught no other occurrences of this
error.
Here's a fix I'm installing for this problem (thanks!); did you catch
any other problems with 4.13?
Separate @c from . in manual/time.texi
From: Alexandre Oliva <aoliva@redhat.com>
for ChangeLog
* manual/time.texi (timegm): Add missing blank after @c.
Reported by Joseph Myers <joseph@codesourcery.com>.
---
manual/time.texi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/manual/time.texi b/manual/time.texi
index 56eada8..d46d2c8 100644
--- a/manual/time.texi
+++ b/manual/time.texi
@@ -939,7 +939,7 @@ available. @code{timelocal} is rather rare.
@c reinitialization, so all issues may arise.
@c tzset dup @mtsenv @mtslocale @ascuheap @asulock @aculock @acsmem @acsfd
@c mktime_internal(gmtime_r) @asulock @aculock
-@c...gmtime_r @asulock @aculock
+@c ..gmtime_r @asulock @aculock
@c ... dup ok
@c tz_convert(!use_localtime) @asulock @aculock
@c ... dup @asulock @aculock
--
Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/ FSF Latin America board member
Free Software Evangelist Red Hat Brazil Toolchain Engineer