This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [MTASCsft PATCH 35/??] MT-, AS- and AC-Safety docs: manual/threads.texi
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Alexandre Oliva <aoliva at redhat dot com>
- Cc: codonell at redhat dot com, libc-alpha at sourceware dot org
- Date: Sat, 01 Feb 2014 00:34:27 -0500
- Subject: Re: [MTASCsft PATCH 35/??] MT-, AS- and AC-Safety docs: manual/threads.texi
- Authentication-results: sourceware.org; auth=none
- References: <ortxelb5zd dot fsf at livre dot home> <or4n4uoncj dot fsf at livre dot home> <orr47seo2e dot fsf_-_ at livre dot home> <52EC5BDE dot 1090006 at redhat dot com> <orioszldhj dot fsf at livre dot home>
On 01/31/2014 10:26 PM, Alexandre Oliva wrote:
> On Feb 1, 2014, "Carlos O'Donell" <carlos@redhat.com> wrote:
>
>> However these functions...
>
>> pthread_key_create
>> pthread_key_delete
>> pthread_getspecific
>> pthread_setspecific
>
>> ...lack saftey notes? Why is that?
>
> My script to check what's missing looked for ^@deftypefu?n only. These
> were (incorrectly?) documented with @item.
>
> I'm not sure I have analyzed these functions; I recall some dependencies
> of others that led me their way (I have comments on 3 out of the 4;
> pthread_key_delete is the one I haven't analyzed yet), but the missing
> @deftypefun made me overlook the definitions in thread.texi.
>
> I could add @safety notes for them, but I'm not sure the formatting will
> come out right under @item. Should I?
Please change them to deftypefun and review them?
Feel free to make it a follow on patch to reduce your set of outstanding patches.
Cheers,
Carlos.