Re: PowerPC: sotruss-lib implementation

[Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>]

On 14-01-2014 20:51, Will Schmidt wrote:
> On Tue, 2013-12-17 at 11:25 -0200, Adhemerval Zanella wrote:
>> Ping.
>>
>> On 10-12-2013 15:38, Adhemerval Zanella wrote:
>>> +#if defined(__PPC64__) || defined(__powerpc64__)
>>> +# if _CALL_ELF != 2
> Any chance there is a #define that would work in place of '2' there? 

I usually use it just to be safe, but I just check GCC defines __powerpc64__ as default since
version 4.3. Changed to just to __powerpc64__.

>
>>> +#  define LA_PPC_REGS          La_ppc64_regs
>>> +#  define LA_PPC_RETVAL        La_ppc64_retval
>>> +#  define LA_PPC_GNU_PLTENTER  la_ppc64_gnu_pltenter
>>> +#  define LA_PPC_GNU_PLTEXIT   la_ppc64_gnu_pltexit
>>> +# else
>>> +#  define LA_PPC_REGS          La_ppc64v2_regs
>>> +#  define LA_PPC_RETVAL        La_ppc64v2_retval
>>> +#  define LA_PPC_GNU_PLTENTER  la_ppc64v2_gnu_pltenter
>>> +#  define LA_PPC_GNU_PLTEXIT   la_ppc64v2_gnu_pltexit
>>> +# endif
>>> +# else
>>> +# define LA_PPC_REGS           La_ppc32_regs
>>> +# define LA_PPC_RETVAL         La_ppc32_retval
>>> +# define LA_PPC_GNU_PLTENTER   la_ppc32_gnu_pltenter
>>> +# define LA_PPC_GNU_PLTEXITA   la_ppc32_gnu_pltexit
> ^ extra 'A' on PLTEXIT.
>
> From the context, I'll infer that big-L "La_..." gets the structures,
> and little-L "la_..." gets the functions as defined below.   The order
> of the defines is backwards wrt the s390 sotruss-lib changes, which had
> me initially thinking this was just random.    May be worth comparing to
> the others and switch lines around so they can be diff'ed, but thats
> really just a cosmetic nit.
>
> Fix the 'A' on PLTEXIT, and otherwise LGTM.

Yes, they are defined at sysdeps/powerpc/bits/link.h and functions are in lowercase indeed.
Fixed the 'A' on PLTEXIT.

Pushed upstream as 2393fc0119fa291ff01b7b912dda2069257c8600.