This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Saturday 12 October 2013 04:25:29 OndÅej BÃlka wrote: > This is another bug in glob with patch in bugzilla from Tom Lee ready, > see https://sourceware.org/bugzilla/show_bug.cgi?id=866 > > Patch itself is ok, what is left is decide if listing dangling symlinks > is desired behavior. it is desired behavior > --- a/posix/glob.c > +++ b/posix/glob.c > @@ -204,7 +204,7 @@ static const char *next_brace_sub (const char *begin, > int flags) __THROW; > > static int glob_in_dir (const char *pattern, const char *directory, > int flags, int (*errfunc) (const char *, int), > - glob_t *pglob, size_t alloca_used); > + glob_t *pglob, size_t alloca_used, int chklnks); > extern int __glob_pattern_type (const char *pattern, int quote) > attribute_hidden; > > @@ -1078,7 +1078,7 @@ glob (pattern, flags, errfunc, pglob) > status = glob_in_dir (filename, dirs.gl_pathv[i], > ((flags | GLOB_APPEND) > & ~(GLOB_NOCHECK | GLOB_NOMAGIC)), > - errfunc, pglob, alloca_used); > + errfunc, pglob, alloca_used, 1); what is this scenario where we're still checking the links ? also, globtest.sh needs updating to make sure this new behavior doesn't regress -mike
Attachment:
signature.asc
Description: This is a digitally signed message part.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |