This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] PowerPC64 ELFv2 ABI 6/6: Bump ld.so soname version number
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 13 Nov 2013 15:38:00 +0000
- Subject: Re: [PATCH] PowerPC64 ELFv2 ABI 6/6: Bump ld.so soname version number
- Authentication-results: sourceware.org; auth=none
- References: <201311131517 dot rADFHZvf003435 at d06av02 dot portsmouth dot uk dot ibm dot com>
On Wed, 13 Nov 2013, Ulrich Weigand wrote:
> Joseph Myers wrote:
>
> > There's also the matter of setting the minimum symbol version in this case
> > to GLIBC_2.19. And having configure tests to ensure the only combinations
> > are the (BE, ELFv1) and (LE, ELFv2) combinations it's desired to support.
>
> So I understand Alan Modra already checked in a change to shlib-versions to
> set the minimum symbol version for powerpc64le. If we only use ELFv2 with
> powerpc64le, is there anything else that needs to be done?
The version there is wrong - it should be GLIBC_2.19, not GLIBC_2.18,
since the 2.18 release did not in fact support little-endian. But apart
from that, just the configure checks.
> As to the configure check, I guess we could add something along these lines
> to the configure.ac file I added:
>
> # We support only the ELFv1 ABI on big-endian powerpc64-linux,
> # and only the ELFv2 ABI on little-endian powerpc64le-linux.
> if test -z "$enable_hacker_mode"; then
> if test "$config_machine" = powerpc64le; then
> if test $libc_cv_ppc64_elfv2_abi = no; then
> AC_MSG_ERROR([Only the ELFv2 ABI is supported on powerpc64le-linux.])
> fi
> else
> if test $libc_cv_ppc64_elfv2_abi = yes; then
> AC_MSG_ERROR([Only the ELFv1 ABI is supported on powerpc64-linux.])
> fi
> fi
> fi
>
> Is this what you were thinking about?
Yes, but I wouldn't have the enable_hacker_mode conditional; make the
errors unconditional just like the existing check that IBM long double is
required in sysdeps/unix/sysv/linux/powerpc/configure.ac. (And it looks
like the check that little-endian powerpc32 isn't supported is still
needed as well.)
--
Joseph S. Myers
joseph@codesourcery.com