This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix country_num element in LC_ADDRESS for C locale
- From: Marko Myllynen <myllynen at redhat dot com>
- To: libc-alpha at sourceware dot org
- Date: Tue, 12 Nov 2013 14:54:28 +0200
- Subject: Re: [PATCH] Fix country_num element in LC_ADDRESS for C locale
- Authentication-results: sourceware.org; auth=none
- References: <mvmmwlaq6dp dot fsf at hawking dot suse dot de>
- Reply-to: myllynen at redhat dot com
Hi,
On 2013-11-12 12:08, Andreas Schwab wrote:
> country_num is a word, not a string.
>
> Andreas.
>
> * locale/C-address.c (_nl_C_LC_ADDRESS): Set country_num to zero
> word instead of empty string.
>
> diff --git a/locale/C-address.c b/locale/C-address.c
> index 060a956..fe6e69e 100644
> --- a/locale/C-address.c
> +++ b/locale/C-address.c
> @@ -38,7 +38,7 @@ const struct __locale_data _nl_C_LC_ADDRESS attribute_hidden =
> { .string = "" },
> { .string = "" },
> { .string = "" },
> - { .string = "" },
> + { .word = 0 },
> { .string = "" },
> { .string = "" },
> { .string = "" },
based on https://sourceware.org/ml/libc-alpha/2013-10/msg00894.html this
looks correct.
I think after this we could agree that country_isbn is meant to be
presented as Unicode points instead of simple numbers, correct?
Thanks,
--
Marko Myllynen