This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ #13724] Do not segfault in pthread_setname_np (x, NULL)
- From: Andreas Schwab <schwab at suse dot de>
- To: OndÅej BÃlka <neleai at seznam dot cz>
- Cc: Rich Felker <dalias at aerifal dot cx>, Carlos O'Donell <carlos at redhat dot com>, libc-alpha at sourceware dot org
- Date: Mon, 07 Oct 2013 18:18:47 +0200
- Subject: Re: [PATCH][BZ #13724] Do not segfault in pthread_setname_np (x, NULL)
- Authentication-results: sourceware.org; auth=none
- References: <20131003122009 dot GA8891 at domone dot podge> <524DCA52 dot 2030609 at redhat dot com> <20131007141928 dot GV20515 at brightrain dot aerifal dot cx> <mvmli25xhm3 dot fsf at hawking dot suse dot de> <20131007145009 dot GX20515 at brightrain dot aerifal dot cx> <mvmhactxhc3 dot fsf at hawking dot suse dot de> <20131007145932 dot GA7119 at domone>
OndÅej BÃlka <neleai@seznam.cz> writes:
> Then do you agree with crashing at pthread_getname_np and waitpid?
>
>
> diff --git a/nptl/sysdeps/unix/sysv/linux/pthread_getname.c b/nptl/sysdeps/unix/sysv/linux/pthread_getname.c
> index f5dc336..e0582fa 100644
> --- a/nptl/sysdeps/unix/sysv/linux/pthread_getname.c
> +++ b/nptl/sysdeps/unix/sysv/linux/pthread_getname.c
> @@ -41,6 +41,10 @@ pthread_getname_np (th, buf, len)
> if (len < TASK_COMM_LEN)
> return ERANGE;
>
> + /* Crash when null buffer is supplied. */
> + if (len)
> + buf[0] = '\0';
> +
Nothing should be done here. Just let any error generated by the
subsequent calls be reported back to the caller.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."