This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] sunrpc/rpc/types.h: Fix OS X build problem.
- From: Jia Liu <proljc at gmail dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: Abdoulaye Walsimou Gaye <awg at embtoolkit dot org>, libc-alpha at sourceware dot org
- Date: Fri, 6 Sep 2013 23:53:22 +0800
- Subject: Re: [PATCH] sunrpc/rpc/types.h: Fix OS X build problem.
- Authentication-results: sourceware.org; auth=none
- References: <1378366884-29968-1-git-send-email-proljc at gmail dot com> <201309052330 dot 31744 dot vapier at gentoo dot org> <CAJBMM-tHnVwU-cpz-4BiEdB75Gxd4o-BK3xqXN_aC+Rkua0Qng at mail dot gmail dot com> <201309060855 dot 20863 dot vapier at gentoo dot org>
Hi Mike,
On Fri, Sep 6, 2013 at 8:55 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Friday 06 September 2013 00:00:22 Jia Liu wrote:
>> On Fri, Sep 6, 2013 at 11:30 AM, Mike Frysinger wrote:
>> > On Thursday 05 September 2013 23:23:06 Jia Liu wrote:
>> >> On Fri, Sep 6, 2013 at 9:13 AM, Mike Frysinger wrote:
>> >> > On Thursday 05 September 2013 09:39:00 Jia Liu wrote:
>> >> >> Is this code looks OK?
>> >> >>
>> >> >> #if defined ( __APPLE_CC__ ) || defined( __FreeBSD__ )
>> >> >> # define __u_char_defined
>> >> >> #endif
>> >>
>> >> I modify the code into this:
>> >>
>> >> #if defined __APPLE_CC__ || defined __FreeBSD__
>> >> # define __u_char_defined
>> >> #endif
>> >>
>> >> and made a test, it still get the same error.
>> >
>> > where did you put the code ? it should have been right above the line:
>> > #ifndef __u_char_defined
>> >
>> > you might have to also add in your new snippet:
>> > # define __daddr_t_defined
>>
>> Thank you, I put
>> #if !defined __APPLE_CC__ && !defined __FreeBSD__
>> above
>> #ifndef __u_char_defined
>> will be right.
>
> i think you're still missing the point. why doesn't this code work ?
Hum, yes, I missing the point, thank you for the point.
>
> #include <sys/types.h>
> #endif
>
> +#if defined __APPLE_CC__ || defined __FreeBSD__
> +# define __u_char_defined
> +# define __daddr_t_defined
> +#endif
>
> #ifndef __u_char_defined
> typedef __u_char u_char;
> -mike
Regards,
Jia