This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v1.1] Randomize memcpy benchmark addresses.
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: Will Newton <will dot newton at linaro dot org>
- Cc: OndÅej BÃlka <neleai at seznam dot cz>, libc-alpha <libc-alpha at sourceware dot org>
- Date: Thu, 5 Sep 2013 16:09:12 +0530
- Subject: Re: [PATCH v1.1] Randomize memcpy benchmark addresses.
- Authentication-results: sourceware.org; auth=none
- References: <20130904163151 dot GB10358 at domone dot kolej dot mff dot cuni dot cz> <20130904165025 dot GA15899 at domone dot kolej dot mff dot cuni dot cz> <CANu=DmjT9Do_1rbVJUGmR=WqGZmwX+KWNvp1QDOQrij3L3q3Xg at mail dot gmail dot com>
On Thu, Sep 05, 2013 at 08:41:02AM +0100, Will Newton wrote:
> >
> > - if (memcmp (dst, src, len) != 0)
> > - {
> > - error (0, 0, "Wrong result in function %s dst \"%s\" src \"%s\"",
> > - impl->name, dst, src);
> > - ret = 1;
> > - return;
> > - }
>
> I am not sure how useful this sanity check is. Obviously the glibc
> memcpy implementation is tested elsewhere but the simple
> implementation isn't.
>
It is here because the string benchmarks were dual purpose before (in
string/test-*) and I had just copied them here in benchtests as a
starting point. The sanity check could be dropped (since it should be
there in string/test-*) but it should be a separate patch since it is
not related in any way to the randomization patch.
Siddhesh