Re: [RFC] Add country_car field to LC_ADDRESS

[Andreas Jaeger <aj at suse dot com>]

On 09/04/2013 03:27 PM, Chris Leonard wrote:
> Although Jakub was advised to submit one patch per locale, a review of
> the nature of the patches proposed shows that it will be more
> productive to commit (and review) at least some of these as bulk
> updates across locales by field.
> 
> 1) country_car is inherently uncontroversial, being a simple lookup to
> a published standard.
> 
> 2) If is far more efficient to review these by field than by locale.
> 
> 3) Submitting 140-odd individual patches would be a ridiculous
> exercise for something with very little potential for adverse impact.
> 
> 4) These have been reviewed by the submitter (Jakub) and an interested
> committer (Chris Leonard).
> 
> QUESTION:
> What I would like to do is to submit the country_car patches as a
> single patch (shown below).  Is this acceptable?
> 
> 
> NEWS will be be updated
> 
> 
> ./localedata/ChangeLog
> 
> 2013-09-04  Chris Leonard  <cjl@sugarlabs.org>

If Jakub is the submitter, I suggest to use his name and not yours.

> 
>     * locales/am_ET Add country_car field to LC_ADDRESS
>     * locales/an_ES Add country_car field to LC_ADDRESS
>     * locales/ar_AE Add country_car field to LC_ADDRESS
We have some simple conventions here:
1) There should be a tab in front of the '*'.
2) There's a ':' after the filename
3) End a sentence with "."
4) Use "Likewise.", for these kind of same changes.

Thus, I would write your entry as:
	* locales/am_ET: Add country_car field to LC_ADDRESS.
	* locales/an_ES: Likewise.
	* locales/ar_AE: Likewise.

The change itself is good and I'm fine with getting it in as a single patch,

Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126