This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PING] [PATCH v2] Fix strrchr regression.
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Liubov Dmitrieva <liubov dot dmitrieva at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 2 Sep 2013 11:52:37 +0200
- Subject: Re: [PING] [PATCH v2] Fix strrchr regression.
- Authentication-results: sourceware.org; auth=none
- References: <20130805173346 dot GA4978 at domone dot kolej dot mff dot cuni dot cz> <20130806083430 dot GA6122 at domone dot kolej dot mff dot cuni dot cz> <20130816110627 dot GA23280 at domone dot kolej dot mff dot cuni dot cz> <20130816121457 dot GA26552 at domone dot kolej dot mff dot cuni dot cz> <20130826134649 dot GB6065 at domone dot kolej dot mff dot cuni dot cz> <20130902092044 dot GC11034 at domone dot kolej dot mff dot cuni dot cz> <CAHjhQ93D6cf8CLcMjuHM6MZB9ou_Bp1z=rm1o9DqwJHs62AzYQ at mail dot gmail dot com>
On Mon, Sep 02, 2013 at 01:39:52PM +0400, Liubov Dmitrieva wrote:
> It looks good for me except several small issues.
>
> You mentioned Intel Corporation. :)
>
> > +/* strrchr with SSE2 without bsf and bsr
> > + Copyright (C) 2011-2013 Free Software Foundation, Inc.
> > + Contributed by Intel Corporation.
>
> And what was the purpose to remove .text?
> > - .text
>
>
> I don't see what is the purpose to include "asm-syntax.h".
> > +#include "asm-syntax.h"
>
I used existing file as template and forgot to check these, I will send
v2.1 shortly.
> --
> Liubov
> Intel Corporation
>