This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hi! On Wed, 29 May 2013 15:53:24 -0700 (PDT), Roland McGrath <roland@hack.frob.com> wrote: > > + /* Avoid warning: case value '0' not in enumerated type 'error_t'. */ > > + ESUCCESS = 0, > > I don't think this is the right comment. If anybody reads this comment at > all, that doesn't tell them much. Perhaps something like: > > /* The value zero always means success and it is perfectly fine for > code to use 0 explicitly (or implicitly, e.g. via Boolean coercion). > Having an enum entry for zero both makes the debugger print the name > for error_t-typed zero values, and prevents the compiler from issuing > warnings about 'case 0:' in a switch on an error_t-typed value. */ Thanks; pushed as commit 883359805325a82f4f291ff85624f141f6c93636 using your above words. GrÃÃe, Thomas
Attachment:
pgpBGtxS8SYtT.pgp
Description: PGP signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |