This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2 v1.2][BZ #14547] Fix CVE-2012-4412
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: Paul Eggert <eggert at cs dot ucla dot edu>, Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 26 Aug 2013 08:59:58 +0200
- Subject: Re: [PATCH 2/2 v1.2][BZ #14547] Fix CVE-2012-4412
- Authentication-results: sourceware.org; auth=none
- References: <20130630164500 dot GF2654 at spoyarek dot pnq dot redhat dot com> <mvmehagsfhm dot fsf at hawking dot suse dot de> <20130821151403 dot GB15273 at spoyarek dot pnq dot redhat dot com> <20130821160808 dot GA4369 at domone dot kolej dot mff dot cuni dot cz> <CAAHN_R2UwiuNAXyqv7QvZzkbfy7vqAMn1EQ-ka82OFUogChVvQ at mail dot gmail dot com> <20130824062248 dot GA16906 at domone dot kolej dot mff dot cuni dot cz> <CAAHN_R2UYzo+N3gcPjUzmkQFOBj6mmKZ2hbHbJW9cfeFthXw7A at mail dot gmail dot com> <5218C3AC dot 1060504 at cs dot ucla dot edu> <20130826034416 dot GC2011 at spoyarek dot pnq dot redhat dot com>
On Mon, Aug 26, 2013 at 09:14:16AM +0530, Siddhesh Poyarekar wrote:
> On Sat, Aug 24, 2013 at 07:31:08AM -0700, Paul Eggert wrote:
> > The empty if-block is a bit easier for me to read than the goto.
> > I got the willies when I saw the goto over the declaration;
> > this goto happens to be valid, but it's just one more silly
> > thing to worry about.
>
> Fair enough - two against one on personal preference (and I don't care
> enough to wait longer), so here's an updated version.
>
OK for me now.