This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PowerPC: use libgcc _Unwind functions to get backtrace


Adhemerval Zanella <azanella@linux.vnet.ibm.com> writes:

> @@ -35,6 +38,43 @@ struct layout
>    void *return_address;
>  };
>  
> +#define __SIGNAL_FRAMESIZE32 64

No need for namespace safety.

> +
> +/* signal trampoline saved area.  */
> +struct signal_frame_32 {
> +  char               dummy[__SIGNAL_FRAMESIZE32];
> +  struct sigcontext  sctx;
> +  mcontext_t         mctx;
> +  /* We don't care about the rest.  */
> +}; 
> +
> +static inline
> +int is_sigtramp_address (unsigned int nip, unsigned int fp)

The function name should start in column 0 with the return type on the
preceding line.

> +{
> +#ifdef SHARED
> +  if (nip == (unsigned long)__vdso_sigtramp32)

Please be consistent about int vs. long.  Space after cast.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]