This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix missing declaration of LC_CTYPE nonascii-case element
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 18 Jul 2013 18:26:02 -0400
- Subject: Re: [PATCH] Fix missing declaration of LC_CTYPE nonascii-case element
- References: <mvmr4exeg0e dot fsf at hawking dot suse dot de>
On 07/17/2013 04:40 AM, Andreas Schwab wrote:
> The LC_CTYPE nonascii-case element is used by the optimized strcasecmp
> family of implementations to check whether the current locale is "hard".
> Failure to declare it causes _nl_load_locale to interpret it as an
> element of string type.
>
> Andreas.
>
> [BZ #15736]
> * locale/categories.def (LC_CTYPE): Add "nonascii-case" element.
> ---
> locale/categories.def | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/locale/categories.def b/locale/categories.def
> index 9a89d2d..8c25378 100644
> --- a/locale/categories.def
> +++ b/locale/categories.def
> @@ -133,6 +133,7 @@ DEFINE_CATEGORY
> DEFINE_ELEMENT (_NL_CTYPE_TRANSLIT_IGNORE_LEN, "ctype-translit-ignore-len", std, word)
> DEFINE_ELEMENT (_NL_CTYPE_TRANSLIT_IGNORE, "ctype-translit-ignore", std, string)
> DEFINE_ELEMENT (_NL_CTYPE_MAP_TO_NONASCII, "map-to-nonascii", std, word)
> + DEFINE_ELEMENT (_NL_CTYPE_NONASCII_CASE, "nonascii-case", std, word)
> ), _nl_postload_ctype)
While this looks correct to me I'm curious why we didn't detect
it when Ulrich fixed support for non-ascii locales in x86-64 in
2011?
Is it because we don't have any test cases using non-ascii?
I'd like to see a testcase added here please.
Cheers,
Carlos.