Re: "define FOO" vs "define\tFOO"

[Mike Frysinger <vapier at gentoo dot org>]

On Wednesday 26 June 2013 13:46:14 Roland McGrath wrote:
> No, we like tabs.  Use regexps in your searches.

to be clear, he's talking about:
#define<space>FOO

vs:
#define<tab>FOO

they render the same when using 8 spaces for tabs, and it semi-frequently gets 
intermixed in our headers.  like bits/fcntl.h still has this problem -- some 
use tabs, some use spaces.  i tend to think "#define<space>FOO" is much more 
common, but i didn't do a survey of our code base.

i'm not saying we should make the change because his regex is simple, but i am 
saying we should make the change because it's pointlessly inconsistent and is 
annoying when making changes (like when indenting the "define" from the "#" and 
have the resulting lines don't match the other half).
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.