This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/2 v4] libc-internal.h: add ALIGN helper macros
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 11 Jun 2013 10:38:41 -0700 (PDT)
- Subject: Re: [PATCH 1/2 v4] libc-internal.h: add ALIGN helper macros
- References: <1369327649-906-1-git-send-email-vapier at gentoo dot org> <1370070444-911-1-git-send-email-vapier at gentoo dot org> <20130603191205 dot 21F8C2C060 at topped-with-meat dot com> <201306032305 dot 58361 dot vapier at gentoo dot org>
> On Monday 03 June 2013 15:12:05 Roland McGrath wrote:
> > I think we should be using inlines rather than macros any time we don't
> > have a strong reason to use macros.
>
> generally we don't do caps inlines though ?
No, they would be lower-case names.
> and using inlines means we now have to deal with types. the current one
> works with any size and does the right thing. if i wrote an inline, i'd
> have to pick a type (size_t? int? long? uint64_t? uintmax_t?) and then
> there'd be ugliness with signed vs unsigned, implicit casts, implicit
> truncation, overhead with casting up to larger than natural types (like
> 64bit on a 32bit system), etc...
I assumed these were meant for addresses, so uintptr_t would always be fine.