This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Avoid overwriting earlier flags in CPPFLAGS-nonlib in benchtests
- From: Andreas Jaeger <aj at suse dot com>
- To: libc-alpha at sourceware dot org
- Date: Sun, 09 Jun 2013 22:03:21 +0200
- Subject: Re: [PATCH] Avoid overwriting earlier flags in CPPFLAGS-nonlib in benchtests
- References: <20130604071907 dot GC13968 at spoyarek dot pnq dot redhat dot com>
On 06/04/2013 09:19 AM, Siddhesh Poyarekar wrote:
Hi,
When setting BENCH_DURATION in CPPFLAGS-nonlib, the current code
assigns the flag to the variable, which overwrites the earlier set
-DNOT_IN_libc=1 flag. This patch fixes it. OK to commit?
Yes, thanks,
Andreas
Siddhesh
* benchtests/Makefile (CPPFLAGS-nonlib): Append values instead
of assigning.
diff --git a/benchtests/Makefile b/benchtests/Makefile
index 6772853..680440f 100644
--- a/benchtests/Makefile
+++ b/benchtests/Makefile
@@ -102,7 +102,7 @@ ifndef BENCH_DURATION
BENCH_DURATION := 10
endif
-CPPFLAGS-nonlib = -DDURATION=$(BENCH_DURATION)
+CPPFLAGS-nonlib += -DDURATION=$(BENCH_DURATION)
# Use clock_gettime to measure performance of functions. The default is to use
# HP_TIMING if it is available.
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126