This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2 v4] [BZ #10283] localedef: align fixed maps to SHMLBA
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 3 Jun 2013 12:14:56 -0700 (PDT)
- Subject: Re: [PATCH 2/2 v4] [BZ #10283] localedef: align fixed maps to SHMLBA
- References: <1369327649-906-1-git-send-email-vapier at gentoo dot org> <1370070444-911-1-git-send-email-vapier at gentoo dot org> <1370070444-911-2-git-send-email-vapier at gentoo dot org>
> --- /dev/null
> +++ b/include/libc-mmap.h
We generally use sysdeps/generic/ for a file intended to have sysdeps variants.
> +/* Using MAP_FIXED with mmap() sometimes requires larger alignment. */
Don't use "function()" in comments. The () is not part of the name.
> +#include <sys/shm.h>
> +#define MAP_FIXED_ALIGNMENT SHMLBA
This is the Linux-specific definition. The generic file should just use
page size, or perhaps the macro should be defined such that the code (or at
least the compiler) can tell statically that there is no need for
additional operations at all when the requirement is no larger than page
size.