This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] [BZ #10283] localedef: align fixed maps to SHMLBA
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: Mike Frysinger <vapier at gentoo dot org>, libc-alpha at sourceware dot org
- Date: Tue, 28 May 2013 20:07:10 -0400
- Subject: Re: [PATCH v2] [BZ #10283] localedef: align fixed maps to SHMLBA
- References: <1369327649-906-1-git-send-email-vapier at gentoo dot org> <1369507293-19498-1-git-send-email-vapier at gentoo dot org> <51A50663 dot 20306 at redhat dot com> <201305281805 dot 15814 dot vapier at gentoo dot org> <20130528231539 dot 7C5CB2C05D at topped-with-meat dot com> <51A54587 dot 2060106 at redhat dot com> <20130529000553 dot 8EAD82C073 at topped-with-meat dot com>
On 05/28/2013 08:05 PM, Roland McGrath wrote:
>>> I don't think you should use include/sys/cdefs.h for that sort of purpose.
>>> If it's internal-only stuff that doesn't directly relate to something else
>>> that's in the API of an installed header, then do it purely in a private
>>> header.
>>
>> Do you care if we use include/libc-internal.h for this purpose?
>
> That's fine enough if there isn't a more specific natural-seeming name for
> this. In this case we have a handful of macros (perhaps they really should
> be inlines) that all go together, so adding an internal header just for
> them (addr-align.h or something) makes sense too.
>
We already have a libc-internal.h that is our catch-all.
I say it should go there, and when we get enough helpers we'll refactor.
c.