This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix comment typos in libio/stdio.h
- From: Murilo Opsfelder Araújo <mopsfelder at gmail dot com>
- To: "Carlos O'Donell" <carlos at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 22 May 2013 21:03:47 -0300
- Subject: Re: [PATCH] Fix comment typos in libio/stdio.h
- References: <1369262403-14172-1-git-send-email-mopsfelder at gmail dot com> <519D58E2 dot 3020307 at redhat dot com>
On Wed, May 22, 2013 at 8:46 PM, Carlos O'Donell <carlos@redhat.com> wrote:
[..]
> May I suggest you look over our todo list for something you
> might find interesting?
>
> http://sourceware.org/glibc/wiki/Development_Todo/Master
I'll check it out and see what I can contribute.
>> This is my very first contribution to glibc and any feedback is welcome.
>
> Unfortunately your patch is wrong.
>
> While the constants say "*_MAX" they are actually minimums.
>
> You are guaranteed at least TMP_MAX unique filenames.
>
> You are guaranteed at least FOPEN_MAX files open simultaneously.
>
> Their names are lamentably confusing but part of the standard.
Sounds I got deluded by the "*_MAX" in the names. Thanks, Carlos.
I've also received some private messages with explanations and I'd
like to thank you all for reviewing and advising.
Murilo