This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Remove ENOSYS tests in libm-test.inc
- From: Andreas Jaeger <aj at suse dot com>
- To: libc-alpha at sourceware dot org
- Date: Thu, 16 May 2013 20:25:35 +0200
- Subject: Re: Remove ENOSYS tests in libm-test.inc
- References: <Pine dot LNX dot 4 dot 64 dot 1305161720430 dot 13497 at digraph dot polyomino dot org dot uk>
On 05/16/2013 07:21 PM, Joseph S. Myers wrote:
Some, but not all, test functions in libm-test.inc run the function
being tested with a particular argument and then skip further testing
if it sets errno to ENOSYS.
This may have made sense before all the libm functions were
implemented for all floating-point formats, but now I think it's more
likely this boilerplate code will cause tests to be wrongly skipped,
because the ENOSYS error comes e.g. from a call to an <fenv.h>
function within the function actually being tested (but it would still
be possible to run the tests of the function being tested with only
minor errors showing up from this), than to show up any hypothetical
future case of a libm function only implemented on some systems. (I
don't think it's likely we'll get more floating-point formats in
future, even if there does exist a VAX GNU/Linux port of an old
version of glibc.)
So this patch removes all those tests for ENOSYS. Tested x86_64 and
x86.
Ok,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126