This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/9] Add vectorized getenv for glibc use


On 05/14/2013 05:00 PM, Andi Kleen wrote:
>>>
>>> That depends on your view of the defined semantics for the new GLIBC_*
>>> environment variables.
>>>
>>> I for one would like to say that they are read at program startup and
>>> never re-read. It makes the most sense for performance and make for a
>>> simple and easy to understand runtime behaviour.
>>>
>>> Does that make sense?
>>
>> Yes, I agree it's probably better behavior. But I thought the patch
>> was also changing (to use caching) the treatment of several
>> preexisting glibc config variables, in which case it is changing the
>> behavior, and if so this should be noted.
> 
> Existing variables are not cached with my patch.
> Only the new GLIBC_* variables.

I was just about to say that. The only things cached
are those that are stored in the global array, which
is GLIBC_* vars. Existing behaviour is preserved, which
is as it should be.

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]