This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/9] Add vectorized getenv for glibc use
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Andi Kleen <ak at linux dot intel dot com>
- Cc: Rich Felker <dalias at aerifal dot cx>, Andi Kleen <andi at firstfloor dot org>, libc-alpha at sourceware dot org
- Date: Tue, 14 May 2013 17:03:15 -0400
- Subject: Re: [PATCH 1/9] Add vectorized getenv for glibc use
- References: <1367537252-30831-1-git-send-email-andi at firstfloor dot org> <1367537252-30831-2-git-send-email-andi at firstfloor dot org> <20130503001819 dot GP20323 at brightrain dot aerifal dot cx> <5191E1AF dot 3010302 at redhat dot com> <20130514141001 dot GT20323 at brightrain dot aerifal dot cx> <20130514210006 dot GI4072 at tassilo dot jf dot intel dot com>
On 05/14/2013 05:00 PM, Andi Kleen wrote:
>>>
>>> That depends on your view of the defined semantics for the new GLIBC_*
>>> environment variables.
>>>
>>> I for one would like to say that they are read at program startup and
>>> never re-read. It makes the most sense for performance and make for a
>>> simple and easy to understand runtime behaviour.
>>>
>>> Does that make sense?
>>
>> Yes, I agree it's probably better behavior. But I thought the patch
>> was also changing (to use caching) the treatment of several
>> preexisting glibc config variables, in which case it is changing the
>> behavior, and if so this should be noted.
>
> Existing variables are not cached with my patch.
> Only the new GLIBC_* variables.
I was just about to say that. The only things cached
are those that are stored in the global array, which
is GLIBC_* vars. Existing behaviour is preserved, which
is as it should be.
Cheers,
Carlos.