This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 0/6] fix wrong program abort on __FD_ELT
- From: KOSAKI Motohiro <kosaki dot motohiro at gmail dot com>
- To: "Carlos O'Donell" <carlos at redhat dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>, Florian Weimer <fweimer at redhat dot com>
- Date: Tue, 30 Apr 2013 19:16:26 -0400
- Subject: Re: [PATCH v2 0/6] fix wrong program abort on __FD_ELT
> (2) Associate the name of the macro with _FORTIFY_SOURCE.
>
> The name "_STRICT_FD_SIZE_CHECK" does not imply it has anything to do
> with _FORTIFY_SOURCE.
>
> Can we name the macro something related? e.g. "_FORTIFY_SOURCE_STRICT_FD_SETSIZE" ?
>
> I don't really care what it is called, but I want to be immediately recognizable
> as a _FORTIFY_SOURCE option.
Carlos,
This is v2 patch and I already sent v4. I rewrote the patch complete
at v4 because Florian strongly requested that the check turn on by
default.
Now, v4 doesn't have _STRICT_FD_SIZE_CHECK nor any build time option.
and check intelligently buffer overflow instead of hard coded 1024.
(by using
__builtin_object_size)
Could you look at v4? It only relax to check against a bitmap
allocated from heap.