This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Avoid undefined behavior in __FD_MASK
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Thu, 11 Apr 2013 13:32:32 -0700 (PDT)
- Subject: Re: [PATCH] Avoid undefined behavior in __FD_MASK
- References: <51651881 dot 2020906 at redhat dot com>
> __fd_mask
> should really be an unsigned type, but changing that is more risky.
That really is the right fix (and then your change is unnecessary).
What risks do you imagine with the type change?
The only thing I can think of is C++ name mangling for function signatures
using the public (but nonstandard) fd_mask type.
Thanks,
Roland