This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use *stat64 instead of *stat in installed programs
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 3 Apr 2013 14:50:09 +0000
- Subject: Re: [PATCH] Use *stat64 instead of *stat in installed programs
- References: <515BE8AA dot 6010407 at redhat dot com> <20130403100311 dot GC3704 at altlinux dot org> <515C0A28 dot 9070303 at redhat dot com>
On Wed, 3 Apr 2013, Florian Weimer wrote:
> On 04/03/2013 12:03 PM, Dmitry V. Levin wrote:
> > On Wed, Apr 03, 2013 at 10:30:34AM +0200, Florian Weimer wrote:
> > > This ensures reliable operation on file systems with inode numbers
> > > which do not fit into 32 bits.
> >
> > Are you sure this fix covers all issues in installed programs related to
> > 64-bit inode numbers?
> > I haven't checked HEAD yet, but in 2.17 I see a bit more of them
> > using non-LFS functions:
>
> These should be harmless because they do not process large files, and only 64
> bit inode numbers can bite them.
Are you sure it's never valid to use any of these programs with large
files? Use of iconv with large files should certainly be valid, although
bug 6050 (that it buffers all of stdin in memory) means it probably can't
practically be used on large files on 32-bit systems at present.
--
Joseph S. Myers
joseph@codesourcery.com