This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Remove MONE and ONE macros

On 03/28/2013 01:34 PM, Siddhesh Poyarekar wrote:

Attached patch removes macros ONE and MONE and uses the constants 1
and -1 directly.  Tested on x86_64.  OK to commit?


	* sysdeps/ieee754/dbl-64/e_log.c (__ieee754_log): Remove MONE
	and ONE.
	* sysdeps/ieee754/dbl-64/mpa.h: Likewise.
	(__pow_mp): Likewise.
	* sysdeps/ieee754/dbl-64/mpatan.c (__mpatan): Likewise.
	* sysdeps/ieee754/dbl-64/mpatan2.c (__mpatan2): Likewise.
	* sysdeps/ieee754/dbl-64/mptan.c (__mptan): Likewise.
	* sysdeps/ieee754/dbl-64/s_atan.c (atan): Likewise.
	* sysdeps/ieee754/dbl-64/s_tan.c (tan): Likewise.

As with ZERO removal, mention mpa.h first and format it properly as:
 	* sysdeps/ieee754/dbl-64/mpa.h (ONE, MONE): Remove define

and say For the rest something like replace ONE, MONE with their values.

Otherwise fine,
 Andreas Jaeger aj@{,} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]