This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v1.1] Remove macros ZERO and MZERO

On 03/28/2013 01:37 PM, Siddhesh Poyarekar wrote:
On Thu, Mar 28, 2013 at 05:18:11PM +0530, Siddhesh Poyarekar wrote:

Attached patch removes the definition of the macros ZERO and MZERO and
adjusts its users to use the values directly.  No regressions due to
this change on x86_64.  OK to commit?

Correction.  I had missed fixing the powerpc bits.  They're included


	* sysdeps/ieee754/dbl-64/e_atan2.c (__ieee754_atan2): Remove

Say replace ZERO and MZERO with their values.

	* sysdeps/ieee754/dbl-64/e_log.c (__ieee754_log): Likewise.
	* sysdeps/ieee754/dbl-64/mpa.h: Likewise.

Make mpa.h the first entry so it's logical what you do and say something like:
(ZERO, MZERO): Remove defines.

	(__pow_mp): Likewise.
	* sysdeps/ieee754/dbl-64/mpatan2.c (__mpatan2): Likewise.
	* sysdeps/ieee754/dbl-64/mpexp.c (__mpexp): Likewise.
	* sysdeps/ieee754/dbl-64/s_atan.c (atan): Likewise.
	* sysdeps/powerpc/power4/fpu/mpa.c (__mul): Likewise.
	(__sqr): Likewise.

Rest is fine, thanks,
 Andreas Jaeger aj@{,} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]