This is the mail archive of the
mailing list for the glibc project.
Re: [v4.1][PATCH] Framework for performance benchmarking of functions
- From: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>
- To: Richard Henderson <rth at twiddle dot net>
- Cc: Siddhesh Poyarekar <siddhesh at redhat dot com>, libc-alpha at sourceware dot org
- Date: Thu, 14 Mar 2013 22:48:51 +0530
- Subject: Re: [v4.1][PATCH] Framework for performance benchmarking of functions
- References: <20130108093115.GA27464@spoyarek.pnq.redhat.com><20130111065846.GC16859@spoyarek.pnq.redhat.com><511CA91C.firstname.lastname@example.org><20130220101719.GA26842@spoyarek.pnq.redhat.com><email@example.com><20130221052256.GI26842@spoyarek.pnq.redhat.com><5125BA3C.firstname.lastname@example.org><20130228121216.GA2358@spoyarek.pnq.redhat.com><20130314083601.GU22471@spoyarek.pnq.redhat.com><email@example.com>
On 14 March 2013 22:38, Richard Henderson <firstname.lastname@example.org> wrote:
> You should have tested at least i386, because you still didn't have the right
> types in the printf for 32-bit.
Sorry about that. I had assumed that Tulio's patch had fixed that on
powerpc32, but I should have verified it.
>> ./bench-skeleton.c:70:11: warning: format ‘%lld’ expects argument of type ‘long long int’, but argument 2 has type ‘unsigned int’ [-Wformat]
> Here's an incremental patch that fixes that and, IMO, makes the results more
Thanks! Would it be OK to commit this and your patch or would you
like me to respin the patch for review?