This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PowerPC's math_ldbl.h

On 02/22/2013 08:11 PM, Adhemerval Zanella wrote:
On 02/22/2013 12:46 PM, Joseph S. Myers wrote:
On Fri, 22 Feb 2013, Adhemerval Zanella wrote:

	* sysdeps/unix/sysv/linux/powerpc/Implies: Add powerpc/fpu prior to
	ieee754/ldbl-128ibm so sysdeps/powerpc/fpu/math_ldbl.h will be included
That's wrong - powerpc --without-fp will be using
sysdeps/unix/sysv/linux/powerpc but can't use sysdeps/powerpc/fpu.

Indeed I didn't take nofpu in consideration. This patch now removes the
sysdeps/unix/sysv/linux/powerpc/Implies and adds the ldbl after ldbl-opt
on sysdeps/powerpc/Implies. This makes sysdeps/powerpc/fpu not appear with
nofpu build while add making it show before sysdeps/ieee754/ldbl-128ibm
so the PPC specific optimization is still used.

2013-02-22 Adhemerval Zanella <>

	* sysdeps/ieee754/ldbl-128ibm/math_ldbl.h (ldbl_pack): Renamed to
	default_ldbl_pack and using as default implementation.

Just a few nits on the changes entry:

We normally active instead of passive, so "Rename to..."

	(ldbl_unpack): Renamed to default_ldbl_unpack and using as default
	* sysdeps/powerpc/fpu/math_ldbl.h (ldbl_extract_mantissa): removed
	redundant definition.

capitalize the entry "Remove..."
	(ldbl_insert_mantissa): Likewise.
	(ldbl_canonicalize): Likewise.
	(ldbl_nearbyint): Likewise.
	(ldbl_pack): Renamed to ldbl_pack_ppc.
	(ldbl_unpack): Renamed to ldbl_unpack_ppc.
	* sysdeps/unix/sysv/linux/powerpc/Implies: Remove file.
	* sysdeps/powerpc/Implies: Add ieee754/ldbl-opt after ieee754/ldbl-128ibm.

The change itself looks fine. Ryan, could you give your blessing, please?

 Andreas Jaeger aj@{,} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]