This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/3 v2] sys/cdefs.h: export __attribute_alloc_size__

From: Roland McGrath <roland at hack dot frob dot com>
To: Mike Frysinger <vapier at gentoo dot org>
Cc: libc-alpha at sourceware dot org
Date: Tue, 29 Jan 2013 16:13:54 -0800 (PST)
Subject: Re: [PATCH 2/3 v2] sys/cdefs.h: export __attribute_alloc_size__
References: <1356817894-16212-1-git-send-email-vapier@gentoo.org><1359085273-5605-1-git-send-email-vapier@gentoo.org><1359085273-5605-2-git-send-email-vapier@gentoo.org>

> 	* include/programs/xmalloc.h: Change __attribute_alloc_size to
> 	__attribute_alloc_size__.
> 	* include/sys/cdefs.h (__attribute_alloc_size): Macro removed.
> 	* misc/sys/cdefs.h (__attribute_alloc_size__): New macro.

This is fine but canonical would be:

	* include/sys/cdefs.h (__attribute_alloc_size): Macro removed.
	* misc/sys/cdefs.h (__attribute_alloc_size__): New macro.
	* include/programs/xmalloc.h: Update uses.

The change is fine.

Thanks,
Roland

References:
- [PATCH 1/3 v2] unify xmalloc prototypes & friends
  - From: Mike Frysinger
- [PATCH 2/3 v2] sys/cdefs.h: export __attribute_alloc_size__
  - From: Mike Frysinger

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]