This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Implement x86 SIZE32/SIZE64 relocations
On Thu, Jan 17, 2013 at 9:25 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Thu, Jan 17, 2013 at 09:10:28AM -0800, H.J. Lu wrote:
>> On Thu, Jan 17, 2013 at 8:53 AM, Jakub Jelinek <jakub@redhat.com> wrote:
>> > On Wed, Jan 16, 2013 at 08:32:54PM -0800, H.J. Lu wrote:
>> >> I checked x86 size relocation support into binutils and
>> >> pushed it to master branch in glibc.
>> >
>> > Please revert it, this should have never been a dynamic relocation.
>> >
>>
>> That is not true. Please see binutils size relocation linker tests.
>> 2 tests scan for run-time size relocation.
>
> You've added a feature that is not really useful for asan, without
> discussing it first. So we just end up with dead code in both glibc and
> gcc.
First, they aren't dead code. Secondly, they are specified in the
psABI:
http://web.archiveorange.com/archive/v/KGyKyS8JaGMawGhL882p
--
H.J.