This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix the value of TWO


On Wednesday, January 16, 2013 14:40:07 Siddhesh Poyarekar wrote:
> Hi,
> 
> During a cleanup I made a mistake and set the value of TWO as -2.0.
> This patch fixes it.  OK to commit?  Running the testsuite for this
> seems pointless (since it did not catch the earlier error) but I've
> done it anyway and can confirm that there were no regressions on
> x86_64.  I've also done another quick audit of the cleanup patches to
> try and ensure that I've not done any similar goof-ups anywhere else.

Yes, this is ok.

If you have a test case that fails, it would be great to add that as 
well,

Andreas

> Siddhesh
> 
> 	* sysdeps/ieee754/dbl-64/mpa2.h: Fix the value of TWO.
> 
> diff --git a/sysdeps/ieee754/dbl-64/mpa2.h
> b/sysdeps/ieee754/dbl-64/mpa2.h index b80bf41..a4a6bdd 100644
> --- a/sysdeps/ieee754/dbl-64/mpa2.h
> +++ b/sysdeps/ieee754/dbl-64/mpa2.h
> @@ -36,7 +36,7 @@
>  #define  ZERO      0.0			/* 0       */
>  #define  ONE       1.0			/* 1       */
>  #define  MONE      -1.0			/* -1      */
> -#define  TWO       -2.0			/* -2      */
> +#define  TWO       2.0			/*  2      */
>  #define  TWO5      0x1.0p5		/* 2^5     */
>  #define  TWO10     0x1.0p10		/* 2^10    */
>  #define  TWO18     0x1.0p18		/* 2^18    */
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]