Re: PATCH: BZ #14664: changing prefix breaks "make check-abi-libc"

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Mon, Dec 10, 2012 at 5:45 AM, Carlos O'Donell
<carlos@systemhalted.org> wrote:
> On Mon, Dec 10, 2012 at 8:34 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>> It just so happens that Andi's ABI is different because he used
>>> different inputs to the build.
>>
>> My patch makes sure that all glibcs configured with the same --prefix=XXX
>> have the same size of _nl_default_dirname.
>
> Sorry, you're right, your patch isn't as bad as removing symbol.
>
> However, your patch weakens the check from consistency with the
> expected default ABI to one of self-consistency e.g. ensuring a
> compiler bug doesn't change the value during a build.

My patch doesn't weaken anything.  It detects any size change
of _nl_default_dirname for the same --prefix=XXX.

As I said before, --prefix=XXX is the part of ABI.  We shouldn't
even assume glibcs configured with different --prefix=XXX
are ABI compatible because they aren't by design.


-- 
H.J.