Re: PATCH: BZ #14664: changing prefix breaks "make check-abi-libc"

["Carlos O'Donell" <carlos at systemhalted dot org>]

On Sun, Dec 9, 2012 at 8:00 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> Hi,
>
> Size of _nl_default_dirname depends on the size of prefix.  This patch
> updates libc.abilist from
>
> _nl_default_dirname D 0x12
>
> where the size of prefix (/usr) is 4, to
>
> _nl_default_dirname D 0xe + sizeof_prefix
>
> and changes scripts/abilist.awk to compute _nl_default_dirname size as
>
> [size of _nl_default_dirname symbol - length of prefix] + sizeof_prefix
>
> Any comments?

Could you please explain how this is different than just deleting the symbol?

Your changes make the test for this particular symbol a tautology.

You check to see that the size is the size you set which is always true.

The check you want is to see if the size you set matches the expected ABI size.

It just so happens that Andi's ABI is different because he used
different inputs to the build.

No matter what we do here the only way for the test to pass is to
support allowing Andi to describe his ABI and use that as the
baseline.

Cheers,
Carlos.