This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Don't check ABI for _nl_default_dirname
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: Andi Kleen <andi at firstfloor dot org>
- Cc: libc-alpha at sourceware dot org, Andi Kleen <ak at linux dot intel dot com>
- Date: Sat, 8 Dec 2012 12:42:34 +0530
- Subject: Re: [PATCH] Don't check ABI for _nl_default_dirname
- References: <1354942935-22669-1-git-send-email-andi@firstfloor.org>
On Fri, Dec 07, 2012 at 09:02:15PM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> As discussed in http://comments.gmane.org/gmane.comp.lib.glibc.alpha/24671
>
> The ABI of _nl_default_dirname depends on the prefix glibc is compiled with.
> For glibcs with non standard prefix _nl_default_dirname changes,
> which causes the ABI check in make check to fail.
>
> The workaround of always configuring with --prefix=/usr didn't really
> work for me because I would have needed to reconfigured/recompiled
> glibc to do any testing outside the test suite.
The discussion above concluded that it would be a better idea to make
the abi check a little smarter, than to remove tests. It would be
nicer if the abilist file format is extended to denote data symbols
that are a function of configuration variables and adjust
expectations. It's a non-trivial task but I'd think of that as the
way forward.
Siddhesh