This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Remove unused variable from powerpc sem_post.c
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: <libc-alpha at sourceware dot org>
- Cc: <ryan dot arnold at gmail dot com>
- Date: Tue, 4 Dec 2012 21:24:53 +0000
- Subject: Remove unused variable from powerpc sem_post.c
Similar to an issue I recently fixed in the generic Linux version of
this file, the powerpc __old_sem_post has a variable used only to
store the result of atomic_increment_val, resulting in a warning.
This patch fixes this warning (tested powerpc32) in the same way as
the fix to the generic file, by casting the result of
atomic_increment_val to (void) instead of initializing an unused
variable with it.
2012-12-04 Joseph Myers <joseph@codesourcery.com>
* sysdeps/unix/sysv/linux/powerpc/sem_post.c (__old_sem_post):
Cast result of atomic_increment_val to (void) instead of storing
in otherwise-unused variable.
diff --git a/nptl/sysdeps/unix/sysv/linux/powerpc/sem_post.c b/nptl/sysdeps/unix/sysv/linux/powerpc/sem_post.c
index 3bf3371..21a65be 100644
--- a/nptl/sysdeps/unix/sysv/linux/powerpc/sem_post.c
+++ b/nptl/sysdeps/unix/sysv/linux/powerpc/sem_post.c
@@ -1,5 +1,5 @@
/* sem_post -- post to a POSIX semaphore. Powerpc version.
- Copyright (C) 2003, 2004, 2007 Free Software Foundation, Inc.
+ Copyright (C) 2003-2012 Free Software Foundation, Inc.
This file is part of the GNU C Library.
Contributed by Paul Mackerras <paulus@au.ibm.com>, 2003.
@@ -56,7 +56,7 @@ __old_sem_post (sem_t *sem)
int *futex = (int *) sem;
__asm __volatile (__lll_rel_instr ::: "memory");
- int nr = atomic_increment_val (futex);
+ (void) atomic_increment_val (futex);
/* We always have to assume it is a shared semaphore. */
int err = lll_futex_wake (futex, 1, LLL_SHARED);
if (__builtin_expect (err, 0) < 0)
--
Joseph S. Myers
joseph@codesourcery.com