This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Cast to int32 first when casting pointer to int64
On Wed, Nov 21, 2012 at 3:53 PM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
> On Wed, 21 Nov 2012, H.J. Lu wrote:
>
>> On Wed, Nov 21, 2012 at 3:20 PM, Joseph S. Myers
>> <joseph@codesourcery.com> wrote:
>> > On Wed, 21 Nov 2012, H.J. Lu wrote:
>> >
>> >> > Referring to "real type" is hardly appropriate here; the point in tgmath.h
>> >> > is distinguishing real and complex types and referring to the standard
>> >> > rules for how tgmath.h determines a common real type. I think you mean
>> >> > something like "intptr_t if P is true, or T if P is false" and then
>> >> > "intptr_t if EXPR has a pointer type, or the type of EXPR otherwise".
>> >>
>> >> How about __integer_type with the updated comments?
>> >
>> > I'd think something more specific such as __integer_if_pointer_type would
>> > be better.
>> >
>> > --
>> > Joseph S. Myers
>> > joseph@codesourcery.com
>>
>> How about this?
>
> I'm not sure include/sys/types.h is the best place for the new macros -
> I'll leave it to others to comment on that - and you need to avoid source
> lines over 79 columns, but the logic of the new macros seems sound to me.
>
Those long lines are hard to break.
--
H.J.